Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • N NetiGoogleSdk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • shopware
  • labs
  • NetiGoogleSdk
  • Merge requests
  • !5

Merged
Created Feb 06, 2020 by Tommy Meier@tmeierDeveloper4 of 4 tasks completed4/4 tasks

33524 custom autoload

  • Overview 3
  • Commits 7
  • Changes 18

1. Why is this change necessary?

The google sdk brings his custom GuzzleHttp library in version ^6.0 but Shopware uses 5.3^. This results into a compatibility issue with BestitKlarnaPayments

2. What does this change do, exactly?

I have created a custom autoloader which will load all requires libraries, except the custom GuzzleHttp one.

3. Describe each step to reproduce the issue or behaviour.

  • Open your browser and navigate to https://github.com/shopware/shopware/tree/5.4
    • Download ZIP
    • Extract ZIP
    • Copy "tests"-Directory into your shopware installation
  • Install "phpunit" if not already
    • Use version ^5.0 for Shopware 5.4 and below
    • Use version >=6.0 for Shopware 5.5 and above
  • Run "phpunit" inside the plugin directory
    • Due autoloading tests you need to test each file in Tests/Functional/*Test.php, otherwise the test will fail
  • Besides the custom autoloader, the general plugin functionality (within NetiSocialLogin) needs to be tested.

4. Please link to the relevant issues (if any).

https://redmine.netinventors.de/issues/33524

5. Checklist

  • I have updated the plugin version and changelog
  • I have set the required labels
  • I can confirm the code style fits our requirements
  • I can confirm no debug output is generated anywhere
Edited Feb 06, 2020 by Jan-Lasse Rombach
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 33524-custom-autoload