Jan Matthiesen (c123703b) at 28 Mar 10:06
Fix icon path
Jan Matthiesen (da10cc92) at 28 Mar 09:56
Jan Matthiesen (67f7757c) at 28 Mar 09:48
Implement debug job
Jan Matthiesen (dd1a917c) at 28 Mar 09:47
Implement debug job
Jan Matthiesen (efe874be) at 28 Mar 09:46
Implement debug job
Jan Matthiesen (c57e2332) at 28 Mar 09:38
Implement debug job
.gitignore
file for better management of ignored directories and files.Jan Matthiesen (da10cc92) at 28 Mar 08:30
Merge branch 'feature/migrate-shopware-cli' into '6.0'
... and 2 more commits
Actionable comments generated: 0
Configuration used: CodeRabbit UI
dev-ops/ecs/composer.lock
is excluded by !**/*.lock
dev-ops/phpunit/composer.lock
is excluded by !**/*.lock
dev-ops/phpunuhi/composer.lock
is excluded by !**/*.lock
dev-ops/psalm/composer.lock
is excluded by !**/*.lock
dev-ops/rector/composer.lock
is excluded by !**/*.lock
src/Resources/store/images/de/000_prologue.jpg
is excluded by !**/*.jpg
src/Resources/store/images/de/100_admin-property.jpg
is excluded by !**/*.jpg
src/Resources/store/images/de/200_admin-property_values.jpg
is excluded by !**/*.jpg
src/Resources/store/images/de/200_frontend-listing.jpg
is excluded by !**/*.jpg
src/Resources/store/images/de/999_epiloque.jpg
is excluded by !**/*.jpg
src/Resources/store/images/en/000_prologue.jpg
is excluded by !**/*.jpg
src/Resources/store/images/en/100_admin-property.jpg
is excluded by !**/*.jpg
src/Resources/store/images/en/200_admin-property_values.jpg
is excluded by !**/*.jpg
src/Resources/store/images/en/200_frontend-listing.jpg
is excluded by !**/*.jpg
src/Resources/store/images/en/999_epiloque.jpg
is excluded by !**/*.jpg
src/Resources/store/store.json
is excluded by !**/*.json
.gitignore (2)
- 17-17: The addition of
/dev-ops/*/composer.lock
to the.gitignore
file is a good practice to avoid committing dependency locks for development tools to the repository.- 38-38: Ignoring
/src/Resources/store/backup
is a good practice to keep backup files out of version control and maintain a clean repository..shopware-extension.yml (1)
- 1-42: The
.shopware-extension.yml
file is well-structured and includes comprehensive details for the Shopware extension configuration. Ensure that paths to files (e.g.,src/Resources/store/de.md
) are correct and that localization settings are comprehensive and accurate.#!/bin/bash # Verify the existence of referenced markdown files for descriptions and manuals. fd 'de.md' src/Resources/store fd 'en.md' src/Resources/store fd 'de_manual.md' src/Resources/store fd 'en_manual.md' src/Resources/store
dev-ops/psalm/psalm.xml.dist (1)
- 33-38: The addition of a suppression rule for
Shopware\Core\Framework\Context::createDefaultContext
is noted. It's generally a good practice to include a comment explaining the reason for specific suppressions to help future maintainers understand the context.Consider adding a comment in the
psalm.xml.dist
file explaining why this particular method is being suppressed.
This update brings enhancements across various aspects of the project, focusing on configuration, code quality, and developer experience. It introduces a configuration file for Shopware extensions, enriching the project with detailed store and localization settings. Additionally, updates to the .gitignore
file ensure better file management by excluding unnecessary files. The psalm.xml.dist
file has been modified to improve code analysis by suppressing specific warnings, optimizing the development workflow.
Files | Change Summary |
---|---|
.gitignore |
Updated to ignore composer lock files, vendor directories, and backup directories. |
.shopware-extension.yml |
Added configuration for Shopware extension including store details, localizations, and more. |
dev-ops/psalm/psalm.xml.dist |
Added suppression rule for createDefaultContext method in Shopware\Core\Framework\Context . |
🐇 ✨ In the code garden, changes bloom,
.gitignore
's updated, giving files room.
With a.yml
for Shopware's delight,
Andpsalm.xml.dist
suppressing fright.
A hop, a skip, in the developer's chase,
These updates bring a smile to the face.
🎉 🐾
⚠ WARNINGFollowing problems were encountered
- Git: Failed to clone repository. Please contact CodeRabbit support.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
There are 3 ways to chat with CodeRabbit:
Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.
Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai
in a new review comment at the desired location with your query. Examples:
@coderabbitai generate unit tests for this file.
@coderabbitai modularize this function.
PR comments: Tag @coderabbitai
in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai generate interesting stats about this repository and render them as a table.
@coderabbitai show all the console.log statements in this repository.
@coderabbitai read src/utils.ts and generate unit tests.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
@coderabbitai pause
to pause the reviews on a PR.@coderabbitai resume
to resume the paused reviews.@coderabbitai review
to trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolve
resolve all the CodeRabbit review comments.@coderabbitai help
to get help.Additionally, you can add @coderabbitai ignore
anywhere in the PR description to prevent this PR from being reviewed.
.coderabbit.yaml
).coderabbit.yaml
file to the root of your repository.# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json
Join our Discord Community to get help, request features, and share feedback.
.gitignore
file for better management of ignored directories and files.
💡 TIP For best results, initiate chat on the files or code changes.
@jmatthiesen, it seems there was an issue accessing the repository to read the file src/Core/Content/Product/Cms/ProductBoxCmsElementResolver.php
and generate unit tests as requested. This could be due to permissions or an issue with the repository's state.
Could you please verify the repository's accessibility or provide any additional details that might help in resolving this issue?
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Read the contents of the specified file.
cat src/Core/Content/Product/Cms/ProductBoxCmsElementResolver.php
Unrecoverable error: Failed to clone repository
The autoloader logic for handling different environments (development and production) is clear and follows standard practices. However, for improved readability and maintainability, consider extracting the paths into variables at the beginning of the file. This approach makes it easier to update paths in the future and reduces duplication.
+ $devAutoloadPath = __DIR__ . '/../../src/Resources/build/vendor/autoload.php';
+ $prodAutoloadPath = __DIR__ . '/../../src/Resources/vendor/autoload.php';
- if (is_file(__DIR__ . '/../../src/Resources/build/vendor/autoload.php')) {
+ if (is_file($devAutoloadPath)) {
// For development
- include __DIR__ . '/../../src/Resources/build/vendor/autoload.php';
+ include $devAutoloadPath;
- } elseif (is_file(__DIR__ . '/../../src/Resources/vendor/autoload.php')) {
+ } elseif (is_file($prodAutoloadPath)) {
// For production
- include __DIR__ . '/../../src/Resources/vendor/autoload.php';
+ include $prodAutoloadPath;
}
‼ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
include __DIR__ . '/../../vendor/autoload.php';
$devAutoloadPath = __DIR__ . '/../../src/Resources/build/vendor/autoload.php';
$prodAutoloadPath = __DIR__ . '/../../src/Resources/vendor/autoload.php';
if (is_file($devAutoloadPath)) {
// For development
include $devAutoloadPath;
} elseif (is_file($prodAutoloadPath)) {
// For production
include $prodAutoloadPath;
}
Actionable comments generated: 1
Configuration used: CodeRabbit UI
dev-ops/ecs/composer.lock
is excluded by: !**/*.lock
dev-ops/phpunit/composer.lock
is excluded by: !**/*.lock
dev-ops/phpunuhi/composer.lock
is excluded by: !**/*.lock
dev-ops/psalm/composer.lock
is excluded by: !**/*.lock
dev-ops/psalm/psalm.xml
is excluded by: !**/*.xml
dev-ops/rector/composer.lock
is excluded by: !**/*.lock
.gitignore (1)
- 17-17: The addition of
/dev-ops/*/composer.lock
to the.gitignore
file is a good practice to prevent committing environment-specific lock files. Ensure this aligns with your project's version control strategy, especially regarding dependency management across different environments.dev-ops/psalm/psalm.xml.dist (1)
- 34-38: The addition of a suppression rule for
Shopware\Core\Framework\Context::createDefaultContext
is understandable to accommodate project-specific requirements. However, ensure that suppressing errors for internal methods is done judiciously to avoid hiding significant issues that could affect the stability or security of the application.
@coderabbitai read src/Core/Content/Product/Cms/ProductBoxCmsElementResolver.php and generate unit tests.
This update introduces enhancements to the project's development and production environments, focusing on configuration and maintenance. It involves the exclusion of certain composer.lock
files from version control, the addition of a new autoloader script for Psalm in the development operations setup, and an update to Psalm's configuration to suppress warnings for a specific internal method. These changes aim to streamline development workflows and reduce unnecessary noise in version control and static analysis outputs.
File(s) | Summary |
---|---|
.gitignore |
Added /dev-ops/*/composer.lock to ignore composer lock files in specific directories. |
.../psalm/psalm-autoloader.php |
Introduced a new autoloader script with environment-specific paths for development and production. |
.../psalm/psalm.xml.dist |
Added a suppression rule for Shopware\Core\Framework\Context::createDefaultContext . |
🐰 ✨
A hop, a skip, in the code we dip,
Locks ignored, with a flip and a zip.
Paths now lead, where before they hid,
Errors silenced, from the grid we rid.
In bytes and bits, our changes we commit,
With each line, our project more fit.
🌟 🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
There are 3 ways to chat with CodeRabbit:
Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.
Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai
in a new review comment at the desired location with your query. Examples:
@coderabbitai generate unit tests for this file.
@coderabbitai modularize this function.
PR comments: Tag @coderabbitai
in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai generate interesting stats about this repository and render them as a table.
@coderabbitai show all the console.log statements in this repository.
@coderabbitai read src/utils.ts and generate unit tests.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
@coderabbitai pause
to pause the reviews on a PR.@coderabbitai resume
to resume the paused reviews.@coderabbitai review
to trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolve
resolve all the CodeRabbit review comments.@coderabbitai help
to get help.Additionally, you can add @coderabbitai ignore
anywhere in the PR description to prevent this PR from being reviewed.
.coderabbit.yaml
).coderabbit.yaml
file to the root of your repository.# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json
Join our Discord Community to get help, request features, and share feedback.
@coderabbitai review
.gitignore
to exclude specific composer.lock
files, enhancing the repository's cleanliness.Jan Matthiesen (e2a2e4f1) at 21 Mar 12:14
Merge branch '44613-migration-to-6.6' into '6.0'